-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use smaller (3 out of 5) quorums for regtest/Travis #2774
Use smaller (3 out of 5) quorums for regtest/Travis #2774
Conversation
Looks good 👍 (even though it does a bit more than what the PR description says ;) ) |
@@ -437,7 +437,7 @@ class CFixedBitSet | |||
vec[p] = (vBytes[p / 8] & (1 << (p % 8))) != 0; | |||
if (vBytes.size() * 8 != size) { | |||
size_t rem = vBytes.size() * 8 - size; | |||
uint8_t m = (uint8_t)(0xff << rem); | |||
uint8_t m = ~(uint8_t)(0xff >> rem); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you like your weird operators ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really :D But give me alternatives please :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
The way it was before resulted in nodes 1-3 being unused and 6-8 being used for these 3 special nodes even though these are masternodes.
It's enough to disable networking for this node.
6f3041d
to
0c25584
Compare
Rebased and force-pushed after merge of #2772 |
Tests are finally green 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
This should reduce the load on Travis quite a bit and thus result in less flaky tests.
Also fixes multiple issues found while fixing tests.